fix: get job run from Optimus DB #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deryrahman
requested changes
Oct 11, 2024
| // JobRun currently gets the job runs from scheduler based on the criteria | ||
| // TODO: later should collect the job runs from optimus | ||
| // GetJobRun gets job runs from optimus DB based on the criteria | ||
| func (h JobRunHandler) GetJobRun(ctx context.Context, req *pb.GetJobRunsRequest) (*pb.GetJobRunsResponse, error) { |
There was a problem hiding this comment.
can we provide test for this handler?
| @@ -146,6 +149,27 @@ func (s *JobRunService) JobRunInput(ctx context.Context, projectName tenant.Proj | |||
| return s.compiler.Compile(ctx, details, config, executedAt) | |||
| } | |||
|
|
|||
| func (s *JobRunService) GetJobRunsByFilter(ctx context.Context, projectName tenant.ProjectName, jobName scheduler.JobName, filters ...filter.FilterOpt) ([]*scheduler.JobRun, error) { | |||
There was a problem hiding this comment.
please also add test for this function as well
| @@ -90,6 +91,56 @@ func (j *JobRunRepository) GetByID(ctx context.Context, id scheduler.JobRunID) ( | |||
| return jr.toJobRun() | |||
| } | |||
|
|
|||
| func (j *JobRunRepository) GetLatestRun(ctx context.Context, project tenant.ProjectName, jobName scheduler.JobName, runState *scheduler.State) (*scheduler.JobRun, error) { | |||
There was a problem hiding this comment.
please also provide test GetLatestRun and GetRunsByTimeRange
|
can you update proto commit reference in Makefile? I believe this should be changed according to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.